feat(cron): Emit event before/after background job execution#51821
feat(cron): Emit event before/after background job execution#51821ChristophWurst wants to merge 1 commit into
Conversation
ChristophWurst
added
2. developing
juliusknorr
force-pushed
the
feat/cron/before-after-events
branch
from
8dbb5f0 to
3fed4f7
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
juliusknorr
force-pushed
the
feat/cron/before-after-events
branch
from
3fed4f7 to
69b6c28
Compare
|
Tested and works for me as well 👍 Anything missing still before moving out of draft state @ChristophWurst ? |
|
I wasn't sure if including job arguments is needed or not, but that can be added later too |
ChristophWurst
requested review from
ArtificialOwl,
nfebe and
provokateurin
and removed request for
a team
haven't tested, code looks good. In case of doubt, we provided the |
|
The API is forward-compatible for extension, we don't need the experimental namespace here |
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
This looks like a reasonable change to me. I actually though we already had this, but guess not... Conflicts need to be resolved, but they look straightforward. Ping me for review again when/if resolved.
5 participants
Summary
Emit events before and after running background jobs.
TODO
Checklist